open-atmos / PyPartMC

Python (and C++) interface to PartMC with Jupyter/Python, Julia and Matlab examples
https://open-atmos.github.io/PyPartMC/
GNU General Public License v3.0
22 stars 9 forks source link

Fractal dimension is hardcoded to be spherical #236

Open jcurtis2 opened 1 year ago

jcurtis2 commented 1 year ago

We currently get around never specifying it and its not a problem due to hardcoding in spherical particles:

https://github.com/open-atmos/PyPartMC/blob/96a89ee6253df42d3571d162ab896fab56a30ad3/src/aero_data.F90#L14-L21

As of now, we do not currently read in the fractal information in run_part_opt.F90. This goes to the issue of having a near duplicate version of the code found in PartMC's main driver partmc.F90. So this will be addressed in #55 and fractal particles can be enabled by deleting Line 19 of code above.

github-actions[bot] commented 1 year ago

Stale issue message

github-actions[bot] commented 11 months ago

Stale issue message

github-actions[bot] commented 9 months ago

Stale issue message

slayoo commented 5 months ago

https://github.com/compdyn/partmc/pull/188