Plugin does not compile

Barryjuait commented 3 years ago

Hi, I tried to install the plugin with the Plugin Installer, but the whole GUI crashes. Instead I tried to compile it manually as follows:

I moved the cloned folder of the Network Events repository into the Plugins folder of the GUI.
I generate the files for VS2019 with CMake form the Build subfolder of the NetworkEvents
I opened the file OE_PLUGIN_NetworkEvents.sln with VS2019 and compiled in Release mode.

Right away I got 3 errors:

Build started... 1>------ Build started: Project: NetworkEvents, Configuration: Release x64 ------ 1>NetworkEvents.cpp 1>C:\Users\Recording Station\Documents\plugin-GUI\Plugins\NetworkEvents\Source\NetworkEvents.h(38,10): fatal error C1083: Cannot open include file: 'ProcessorHeaders.h': No such file or directory 1>NetworkEventsEditor.cpp 1>C:\Users\Recording Station\Documents\plugin-GUI\Plugins\NetworkEvents\Source\NetworkEventsEditor.h(28,10): fatal error C1083: Cannot open include file: 'EditorHeaders.h': No such file or directory 1>OpenEphysLib.cpp 1>C:\Users\Recording Station\Documents\plugin-GUI\Plugins\NetworkEvents\Source\OpenEphysLib.cpp(24,10): fatal error C1083: Cannot open include file: 'PluginInfo.h': No such file or directory 1>Generating Code... 1>Done building project "NetworkEvents.vcxproj" -- FAILED. 2>------ Skipped Build: Project: INSTALL, Configuration: Release x64 ------ 2>Project not selected to build for this solution configuration ========== Build: 0 succeeded, 1 failed, 2 up-to-date, 1 skipped ==========

What am I missing??

Thank you very much,

Sebastian

anjaldoshi commented 3 years ago

Hi Sebastian,

First of all, lets make sure why installing NetworkEvents plugin via Plugin Installer is making the GUI crash for you. Are you able to install any other plugin via Plugin Installer? Does that crash the GUI too? If you are not able to install any of the plugins, can you make sure you built the GUI in Release x64 mode and not in Debug mode. Plugins installed via plugin installer only work with GUI built in Release mode.

Regarding building the plugin from source, you cannot clone the plugin inside the GUI's Plugins directory. That directory is reserved for Plugins shipped with the GUI and not external plugins like NetworkEvents. We recommend cloning all external plugins inside a separate directory (create a directory called OEPlugins) which is at the same level as the plugin-GUI directory. So for you, NetworkEvents should be cloned inside C:\Users\Recording Station\Documents\OEPlugins. Then you can build the plugins after generating build files. Details regarding this is avialable on our wiki over here and our new docs site will have the details regarding this added soon.

Anjal

Barryjuait commented 3 years ago

@anjaldoshi Having the folder out of the plugin-GUI worked very well, thank you very much! :D

open-ephys-plugins / network-events

Plugin does not compile #5