Fix one camera bug and clean up code

open-forest-observatory / geograypher

Multiview Semantic Reasoning with Geospatial Data

BSD 3-Clause "New" or "Revised" License

10 stars 4 forks source link

Fix one camera bug and clean up code #100

Closed asidhu0 closed 3 months ago

asidhu0 commented 3 months ago

Addressed the feedback on the previous merged PR #89.

There was an issue where if there was only one camera and no frustum scale, the code would break. In this scenario, I decided to set the frustum_scale to 1. Would this be a good default value?

russelldj commented 3 months ago

Nice work. Yeah, I think 1 is a very reasonable default. The user can always provide a value if they see that it's way off, it's just confusing if they have to debug logic errors that cause an error.

russelldj commented 3 months ago

Also this is our 100th issue/PR :smiley:

russelldj commented 3 months ago

Double also, can you delete your feature branch now that this is merged?