Update Camera.get_subset_ROI to support mesh coordinate system

open-forest-observatory / geograypher

Multiview Semantic Reasoning with Geospatial Data

BSD 3-Clause "New" or "Revised" License

10 stars 4 forks source link

Update Camera.get_subset_ROI to support mesh coordinate system #112

Closed Ruprabhu25 closed 3 days ago

Ruprabhu25 commented 2 months ago

Added a flag for users to indicate if the ROI provided is geospatial or not. If not, the function determines if the ROI provided is geospatial if a CRS is provided in the ROI. For mesh coordinates, image locations were derived from camera locations / the camera_to_world transformation matrix instead of lon_lat information. Also added support for shapely.geometry.Polygon and shapely.geometry.Multipolygon; these ROIs are loaded into a geodataframe and operated on as usual.

russelldj commented 1 month ago

Is this ready to merge or do you want to include unit tests?

russelldj commented 3 days ago

Nice work @Ruprabhu25 and @asidhu0!