search

open-forest-observatory / geograypher

Multiview Semantic Reasoning with Geospatial Data
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Black Formatter not formatting code during open pull request #124

Closed asidhu0 closed 2 days ago

asidhu0 commented 4 days ago

During an open pull request, if isinstance(ROI, (Polygon,MultiPolygon)): did not get auto-formatted to if isinstance(ROI, (Polygon, MultiPolygon)):, (note the missing space).

However, if you run the same version of black as specified in github actions log in the command line the spacing takes effect.

One thing I observed from the logs is the Black auto-formats properly after a open pull request is merged into main. My initial suspicion is that this might have to do something with black having to wait for isort to finish execution and then running but more observation is needed.

russelldj commented 3 days ago

As you suspected, the black changes are being applied after the merge. See 8ffa8bed.