search

open-forest-observatory / geograypher

Multiview Semantic Reasoning with Geospatial Data
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Add `__str__` for major classes #21

Open russelldj opened 8 months ago

russelldj commented 8 months ago

It would help with debugging to be able to print out a string representation that contains some useful information. For example, what files the data is loaded from and the size of major data attributes. For example, number of vertices in a mesh or number of cameras in a set.

amitsgh commented 8 months ago

Subject: Request to work on issue

Dear @russelldj, I'd like to work on above issue. Kindly consider assigning it to me.

Best Regards

russelldj commented 8 months ago

Hi @amitsgh, Thanks for your interest in this! Please feel free to work on this and ask any questions you need. When you're ready, you can submit a PR with the changes.

You are our first external collaborator. I'll try to get some style guide documentation up for you, but generally we use black and isort as our main formatters. Also, we should probably get a Contributor License Agreement set up. I'll need to talk with @youngdjn about that, which may take a few days since he's currently out.

Out of curiosity, how did you find out about the project? Have you been able to run it?

amitsgh commented 8 months ago

Hey @russelldj,

I am new to this open-source contribution thing, so I generally search issues label:'good first issue'. This is how I came across this repo.

I have read the readme file and checked the work on OFO website, thus decided to give it a try in contributing to it. I haven't set it up locally, but I will now, as I was waiting for the approval because I don't know how things generally works in open source.

amitsgh commented 8 months ago

@russelldj, I am not clear on how to set it up locally, according to this https://github.com/open-forest-observatory/multiview-prediction-toolkit#installation, I current don't have access to /ofo-share.

russelldj commented 8 months ago

@amitsgh, sorry for the confusion. You don't need access to /ofo-share, it just is a simpler way to use the tool for internal OFO team members. You'll need to follow the steps for creating a new environment. I updated the documentation to make this clearer.

Currently, you won't have access to any of the example data. @youngdjn, do you have any thoughts about what we could use as publicly-available data or if we can send something to @amitsgh? I'm happy to take the conversation offline.

russelldj commented 8 months ago

We added some formatting guidelines here.