search

open-forest-observatory / geograypher

Multiview Semantic Reasoning with Geospatial Data
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Deal with potential geographic (unprojected) CRSs beyond EPSG:4326 #40

Closed youngdjn closed 1 week ago

youngdjn commented 7 months ago

For example, EPSG:4269. I think it's quite unlikely that users would have data in a geographic CRS other than 4326 but it is possible. I don't know how to get an exhaustive list. Potential fix: check whether the units of the CRS are in degrees and raise an error if so.

https://github.com/open-forest-observatory/multiview-mapping-toolkit/blob/506338e882f7701ab54b20189148be64ec3e554e/multiview_prediction_toolkit/utils/geospatial.py#L14C4-L14C4

russelldj commented 7 months ago

It looks like this can be done more flexibly with is_projected in pyproj.

youngdjn commented 7 months ago

Sounds perfect!

On Mon, Nov 27, 2023 at 7:02 AM David Russell @.***> wrote:

It looks like this can be done more flexibly with is_projected https://pyproj4.github.io/pyproj/stable/api/crs/crs.html#pyproj.crs.CRS.is_projected in pyproj.

— Reply to this email directly, view it on GitHub https://github.com/open-forest-observatory/multiview-mapping-toolkit/issues/40#issuecomment-1828006174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMF4LTDLSHLS3ZVR3VYN2LYGSTPFAVCNFSM6AAAAAA73PX4VSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGAYDMMJXGQ . You are receiving this because you authored the thread.Message ID: <open-forest-observatory/multiview-mapping-toolkit/issues/40/1828006174@ github.com>