search

open-forest-observatory / geograypher

Multiview Semantic Reasoning with Geospatial Data
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Add an explicit 'label_column_name' argument instead of using the 'texture_kwargs' dict #41

Closed youngdjn closed 5 months ago

youngdjn commented 7 months ago

Since TexturedPhotogrammetryMesh() is a major user entrypoint, it would be ideal to make it as intuitive as possible. I think an explicit label_column_name argument would be more intuitive than a texture_kwargs dict with a column_name key. Ideally this would be done to load_texture too, though if necessary the dict could be created internally before calling load_texture. It looks like column_name is the only key ever used in this dict (currently) anyway?

https://github.com/open-forest-observatory/multiview-mapping-toolkit/blob/506338e882f7701ab54b20189148be64ec3e554e/multiview_prediction_toolkit/meshes/meshes.py#L49

russelldj commented 7 months ago

This is a good idea. The original motivation for having a kwarg dict was I thought there might be a lot of optional params across all the input modalities. But this never ended up being required.

russelldj commented 5 months ago

This was added as texture_column_name