Set frustum scale for metashape meshes

open-forest-observatory / geograypher

Multiview Semantic Reasoning with Geospatial Data

BSD 3-Clause "New" or "Revised" License

10 stars 4 forks source link

Set frustum scale for metashape meshes #89

Closed asidhu0 closed 3 months ago

asidhu0 commented 3 months ago

This enables the user to specify the frustum_scale in the jupyter notebooks. The size of the frustums shown in the mesh can be modified by changing the frustum_scale parameter.

russelldj commented 3 months ago

The functionality looks good. But since this math is a little weird, can you add some comments about what is going on?

Also, can you add a line in the method docstring for frustum_scale? And chose a sensible default value for it?

russelldj commented 3 months ago

Can you link this to #58 so it gets closed when this is merged?

russelldj commented 3 months ago

I know you're busy this week, and this is useful, so I'm just going to merge. If you could address the feedback on a follow on PR that would be great.