search

open-guides / og-aws

📙 Amazon Web Services — a practical guide
Creative Commons Attribution 4.0 International
35.57k stars 3.85k forks source link

broken link fix #799

Open eslerm opened 2 years ago

eslerm commented 1 year ago

Hi @darigovresearch

Can you check https://github.com/open-guides/og-aws/pull/799/files? Line 1814 needs to be joined with line 1815 with the domain name added.

Looks like this on the readme currently: https://github.com/open-guides/og-aws#cloudformation-alternatives-and-lock-in

darigovresearch commented 1 year ago

@eslerm you can update your pull request to make the update you want, you can do that by clicking on the three dots then Edit file on the Files changed tab. Maybe it would be best to do an indented bullet point rather than merging the two into a bullet point like on line 1795.

image

Could you also clarify what you mean by ... with the domain name added?

All URLs in your changes appear to work and have their domains

eslerm commented 1 year ago

The original patch is as intended.

I will wait for projects maintainers to review.

darigovresearch commented 1 year ago

@eslerm sounds good.

Do any maintainers require anything else for this pull request to be merged?