open-o11y / prometheus-sample-app

A sample app that generates Prometheus metrics

10 stars 6 forks source link

Metrics generator enhancement #5

Closed alexperez52 closed 3 years ago

alexperez52 commented 3 years ago

Description

This update enhances the metrics generator by allowing CLI input as well as config file setup. A configuration file is required to set default arguments however, these defaults can be overwritten by CLI input The usage can be found in the README.

Type of change

Enhancement

Aneurysm9 commented 3 years ago

Please add .DS_Store and prometheus-sample-app to .gitignore and purge them from this history. The former is OS X metadata that is irrelevant to this project and the latter is a binary build artifact that can be regenerated from the tracked source and does not provide useful version history information. The build artifact is also relatively very large and would consistently add to the repository size.

alexperez52 commented 3 years ago

One issue to fix with the default/config override logic, otherwise LGTM.

Great ! I appreciate the reviews 😃