search

open-obfuscator / o-mvll

:electron: O-MVLL is a LLVM-based obfuscator for native code (Android & iOS)
https://obfuscator.re/omvll
Apache License 2.0
574 stars 62 forks source link

In CMake use add_subdirectory() instead of include() #11

Closed weliveindetail closed 1 year ago

weliveindetail commented 1 year ago

Moving on from include() to add_subdirectory() is the mayor change in this PR. add_subdirectory() mirrors the directory structure from the source-tree to the build-tree which isolates targets and their properties in a hierarchical structure. This is idiomatic usage in CMake.

On the way, I added two more fixes. Please find more details in the individual commit messages.

romainthomas commented 1 year ago

I completely agree with these changes. Back in the days, I read that include(...) would have been better than add_subdirectory(...) but I guess it was wrong.

Thank you