open-rmf / rmf-web

Apache License 2.0
87 stars 41 forks source link

Fix ghpages workflow #1019

Closed aaronchongth closed 1 month ago

aaronchongth commented 1 month ago

For future reference and more context, the server's public URL had to be behind a proxy to take effect was already documented 3 years ago, https://github.com/open-rmf/rmf-web/blob/main/packages/api-server/api_server/default_config.py#L9-L12, with some more docs from fastapi, https://fastapi.tiangolo.com/advanced/behind-a-proxy/#proxy-with-a-stripped-path-prefix

I'm just more surprised it worked in the past, perhaps it was the major version updates that broke the behavior.