open-rmf / rmf-web

Apache License 2.0
87 stars 41 forks source link

`node-canvas` does not have prebuilt binaries for node 22 #1023

Closed koonpeng closed 3 days ago

koonpeng commented 1 week ago

Before proceeding, is there an existing issue or discussion for this?

OS and version

Ubuntu 24.04

Open-RMF installation type

Source build

Other Open-RMF installation methods

No response

Open-RMF version or commit hash

main

ROS distribution

Jazzy

ROS installation type

Binaries

Other ROS installation methods

No response

Package or library, if applicable

No response

Description of the bug

The version of node-canvas (v2) used does not have prebuilt binaries for the latest node lts (node 22). It can still be built from source but you will need to install several system dependencies. We should update to node-canvas >= 3 which uses the newer NAPI api.

Steps to reproduce the bug

pnpm install on node 22.

Expected behavior

No response

Actual behavior

No response

Additional information or screenshots

No response

koonpeng commented 1 week ago

This is causing nightly to fail.

zzttqu commented 5 days ago

I have the same problem when I install the dependencies on ros2-jazzy. After I remove the canvas from package.json, it seems work well.