open-rmf / rmf-web

Apache License 2.0
83 stars 39 forks source link

Allow pydantic 2.8.2 to be installed after python 3.8 following pypi #987

Closed aaronchongth closed 1 month ago

aaronchongth commented 1 month ago

What's new

This fixes the issue of pipenv-install setting up pydantic==1.10.7 when developing locally on Ubuntu Jammy + ROS 2 Humble.

It is a little odd that setting up the web stack in docker doesn't run into this issue.

Updated the markers to follow https://pypi.org/project/pydantic/. The markers are listed based on the environment where pipenv lock was run, resulting in python >= 3.12

Self-checks

aaronchongth commented 1 month ago

yeah sorry forgot to post my reply earlier, doing a pipenv lock on noble with this commit will revert it back to python >= 3.12 so I agree this is a little weird, we'll keep a mental note on this for deployments. But this PR is not valid, thanks for checking through