search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
552 stars 113 forks source link

feat: add french translation #38

Closed CBID2 closed 1 year ago

CBID2 commented 1 year ago

Description

This PR adds a French translation for the course. This will aid French contributors in starting their open source journey.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes #16

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit 984266df459ca0e8e5e080e2060c7b51f866bf39
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/650bc3a62c763a0008a369f3
Deploy Preview https://deploy-preview-38--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CBID2 commented 1 year ago

Bonjour @geoffreylgv! J'ai seulement fait file 1 et une partie du file 2, donc tu peux fais le reste. Merci beaucoup pour assiste moi! :)

geoffreylgv commented 1 year ago

Alright, I'll check them and work on them

CBID2 commented 1 year ago

Alright, I'll check them and work on them

Hey @geoffreylgv. How are things going?

geoffreylgv commented 1 year ago

Alright, I'll check them and work on them

Hey @geoffreylgv. How are things going?

Hi @CBID2, everything is good so far, apart from @antonio-pedro99's feedback, I'll take them in count, But what about paraphs? I'm gonna test to see the render.

I completed the how to contribute file (Actually four files completed)

CBID2 commented 1 year ago

Alright, I'll check them and work on them

Hey @geoffreylgv. How are things going?

Hi @CBID2, everything is good so far, apart from @antonio-pedro99's feedback, I'll take them in count, But what about paraphs? I'm gonna test to see the render.

I completed the how to contribute file (Actually four files completed)

Hey @geoffreylgv. I don't see the changes. Did you accept my invite to my fork?

geoffreylgv commented 1 year ago

Hey @geoffreylgv. I don't see the changes. Did you accept my invite to my fork?

Yes, I did some changes on it, check the branch completing-french-translation sending PR to your branch adding-french-translation

CBID2 commented 1 year ago

completing-french-translation

I see them @geoffreylgv! :) Tres bon! :)

geoffreylgv commented 1 year ago

completing-french-translation

I see them @geoffreylgv! :) Tres bon! :)

Thanks

CBID2 commented 1 year ago

completing-french-translation

I see them @geoffreylgv! :) Tres bon! :)

Thanks

I cherry picked some of your commits @geoffreylgv. I hope you don't mind.

geoffreylgv commented 1 year ago

I cherry picked some of your commits @geoffreylgv. I hope you don't mind.

Yeah, no worries

geoffreylgv commented 1 year ago

Nice, @CBID2 did you check them out ? I'll continue those remaining and have one line per sentence like @antonio-pedro99 suggested Thank you and good work. Almost 11:30pm 😄

CBID2 commented 1 year ago

Nice, @CBID2 did you check them out ? I'll continue those remaining and have one line per sentence like @antonio-pedro99 suggested Thank you and good work. Almost 11:30pm 😄

Yeah they're good! :) Ok bon nuit @geoffreylgv

geoffreylgv commented 1 year ago

Nice, @CBID2 did you check them out ? I'll continue those remaining and have one line per sentence like @antonio-pedro99 suggested Thank you and good work. Almost 11:30pm 😄

Yeah they're good! :) Ok bon nuit @geoffreylgv

Merci, Bonne nuit !

CBID2 commented 1 year ago

Nice, @CBID2 did you check them out ? I'll continue those remaining and have one line per sentence like @antonio-pedro99 suggested Thank you and good work. Almost 11:30pm 😄

Yeah they're good! :) Ok bon nuit @geoffreylgv

Merci, Bonne nuit !

When you wake up @geoffreylgv, check out some of my commits. I cherry-picked them into your PR.

geoffreylgv commented 1 year ago

Nice, @CBID2 did you check them out ? I'll continue those remaining and have one line per sentence like @antonio-pedro99 suggested Thank you and good work. Almost 11:30pm 😄

Yeah they're good! :) Ok bon nuit @geoffreylgv

Merci, Bonne nuit !

When you wake up @geoffreylgv, check out some of my commits. I cherry-picked them into your PR.

Morning @CBID2, ok I'll check it out

geoffreylgv commented 1 year ago

Hello @CBID2, hope you are doing great. I have completed the rest of translation. Kindly check it to merge on the fork repo and your branch, then it can be propose here. Thanks.

CBID2 commented 1 year ago

Hello @CBID2, hope you are doing great. I have completed the rest of translation. Kindly check it to merge on the fork repo and your branch, then it can be propose here. Thanks.

Hello @geoffreylgv. Your changes did not show up on my branch when I tried to merge the branches together, so I cherry-picked your commits. Things look pretty well in opinion

geoffreylgv commented 1 year ago

Alright, thanks

CBID2 commented 1 year ago

Hello @CBID2, hope you are doing great. I have completed the rest of translation. Kindly check it to merge on the fork repo and your branch, then it can be propose here. Thanks.

Hey @geoffreylgv. Your commits have been cherry-picked to my branch. They look pretty good! :)

geoffreylgv commented 1 year ago

Hello @CBID2, hope you are doing great. I have completed the rest of translation. Kindly check it to merge on the fork repo and your branch, then it can be propose here. Thanks.

Hey @geoffreylgv. Your commits have been cherry-picked to my branch. They look pretty good! :)

Yeah nice. It was nice to re-read this doc 😄

CBID2 commented 1 year ago

Hello @CBID2, hope you are doing great. I have completed the rest of translation. Kindly check it to merge on the fork repo and your branch, then it can be propose here. Thanks.

Hey @geoffreylgv. Your commits have been cherry-picked to my branch. They look pretty good! :)

Yeah nice. It was nice to re-read this doc 😄 I agree. I just added a Language Support section en francais. Check it out

CBID2 commented 1 year ago

@BekahHW, do you recommend that @geoffreylgv and I translate the sidebars into French too?

CBID2 commented 1 year ago

Comme la pizza, l'open source est destiné à être partagé avec tout le monde. Cliquez sur les liens ci-dessous pour suivre ce cours dans les différentes langues suivantes.

Done @geoffreylgv

CBID2 commented 1 year ago

Very nice. That's perfect!

Yup!

BekahHW commented 1 year ago

@BekahHW, do you recommend that @geoffreylgv and I translate the sidebars into French too?

I do!

geoffreylgv commented 1 year ago

Hello @CBID2 @BekahHW Here are some approaches I have found to the navbarfor multi languages Tell me, what do you think ?

1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> --> It has not enough effect on the whole pages

3oss

2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language

2oss

CBID2 commented 1 year ago

Hello @CBID2 @BekahHW

Here are some approaches I have found to the navbarfor multi languages

Tell me, what do you think ?

1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> -->

It has not enough effect on the whole pages

3oss

2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language

2oss

I like number 2 @geoffreylgv. Where did you learn that?

geoffreylgv commented 1 year ago

Hello @CBID2 @BekahHW Here are some approaches I have found to the navbarfor multi languages Tell me, what do you think ? 1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> --> It has not enough effect on the whole pages 3oss

2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language 2oss

I like number 2 @geoffreylgv. Where did you learn that?

It's from the documentation of Docsify, very cool, things are really simple

CBID2 commented 1 year ago

Hello @CBID2 @BekahHW

Here are some approaches I have found to the navbarfor multi languages

Tell me, what do you think ?

1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> -->

It has not enough effect on the whole pages

3oss

2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language

2oss

I like number 2 @geoffreylgv. Where did you learn that?

It's from the documentation of Docsify, very cool, things are really simple

Can you link to the page please @geoffreylgv?

geoffreylgv commented 1 year ago

Hello @CBID2 @BekahHW

Here are some approaches I have found to the navbarfor multi languages

Tell me, what do you think ?

1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> -->

It has not enough effect on the whole pages

3oss

2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language

2oss

I like number 2 @geoffreylgv. Where did you learn that?

It's from the documentation of Docsify, very cool, things are really simple

Can you link to the page please @geoffreylgv?

Alright, will send it to the forked repo

CBID2 commented 1 year ago

Hello @CBID2 @BekahHW

Here are some approaches I have found to the navbarfor multi languages

Tell me, what do you think ?

1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> -->

It has not enough effect on the whole pages

3oss

2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language

2oss

I like number 2 @geoffreylgv. Where did you learn that?

It's from the documentation of Docsify, very cool, things are really simple

Can you link to the page please @geoffreylgv?

Alright, will send it to the forked repo

Lol I mean link the page from Docsify's website where they show method #2 @geoffreylgv. 😆

antonio-pedro99 commented 1 year ago

@geoffreylgv @CBID2 nice work guys.

As the Portuguese translation is also going on, I would suggest opening a different PR for language navbar. After successfully merged it, we can rebase our branches to a uniform way to show the navbar for both Portuguese, French and others languages.

antonio-pedro99 commented 1 year ago

Hello @CBID2 @BekahHW Here are some approaches I have found to the navbarfor multi languages Tell me, what do you think ? 1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> --> It has not enough effect on the whole pages 3oss

2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language 2oss

I like number 2 @geoffreylgv. Where did you learn that?

I do not think number 2 is the way to go, IMHO. Say we have more than 10 languages supported? How would it look? I would stay with number 1.

CBID2 commented 1 year ago

Hello @CBID2 @BekahHW Here are some approaches I have found to the navbarfor multi languages Tell me, what do you think ? 1st Behavior, by commenting the custom CSS <!-- <link rel="stylesheet" href="./styles/custom.css" /> --> It has not enough effect on the whole pages 3oss 2nd Behavior, Without commenting the custom CSS, but adding only the flag of the language 2oss

I like number 2 @geoffreylgv. Where did you learn that?

I do not think number 2 is the way to go, IMHO. Say we have more than 10 languages supported? How would it look? I would stay with number 1.

Oooh good point @antonio-pedro99! :) Doing it as a dropdown menu does give more options. However, my concern is that it does not impact the entire page.

geoffreylgv commented 1 year ago

Oupssss ! Sorry, I hadn't seen the reply earlier

No worries, it impacts the whole code, Will work on it.

So to have all pages with the language selected /translations /fr /_layouts/navbar/navbar.md /_layouts/ sidebar/sidebar.md README.md 1-Intro.md 2-Why.md

In the _layouts: sidebar.md and navbar.md, all the content should be translated to the targeted language The above example is for French.

CBID2 commented 1 year ago

Oupssss ! Sorry, I hadn't seen the reply earlier

No worries, it impacts the whole code, Will work on it.

So to have all pages with the language selected /translations /fr /_layouts/navbar/navbar.md /_layouts/ sidebar/sidebar.md README.md 1-Intro.md 2-Why.md

In the _layouts: sidebar.md and navbar.md, all the content should be translated to the targeted language The above example is for French.

It looks great in the previews @geoffreylgv! :) @antonio-pedro99, I think there are two ways we can go about this:

  1. Merge the French translation PR, merge the Portuguese translation PR, and then do a separate PR where we add the Portuguese section to the navigation bar or
  2. Do the navigation sidebar for the Portuguese translation and cherry-pick your commits for that feature to the French translation PR. Which one do you recommend?
antonio-pedro99 commented 1 year ago

It seems to be a good idea.

But let's keep it simple. Adding a PR with the navbar for translations is a simple way to do this.

In both approaches you mentioned we might have merge conflicts. I don't see any reason to build the navbar separatetly for each translation and them try to merge.

Let's add a navbar for languages suport and start with englih only in a different PR.

We can then rebase our PRs and make changes accordingly and avoid merge conflicts that might occur.

CBID2 commented 1 year ago

It seems to be a good idea.

But let's keep it simple.

Adding a PR with the navbar for translations is a simple way to do this.

In both approaches you mentioned we might have merge conflicts. I don't see any reason to build the navbar separatetly for each translation and them try to merge.

Let's add a navbar for languages suport and start with englih only in a different PR.

We can then rebase our PRs and make changes accordingly and avoid merge conflicts that might occur.

I guess we can do it that way @antonio-pedro99

CBID2 commented 1 year ago

It seems to be a good idea. But let's keep it simple. Adding a PR with the navbar for translations is a simple way to do this. In both approaches you mentioned we might have merge conflicts. I don't see any reason to build the navbar separatetly for each translation and them try to merge. Let's add a navbar for languages suport and start with englih only in a different PR. We can then rebase our PRs and make changes accordingly and avoid merge conflicts that might occur.

I guess we can do it that way @antonio-pedro99

Hey @geoffreylgv. Since we're going with @antonio-pedro99's suggestion to do a separate PR for the navbar, do you mind if I revert the commit you made for it?

geoffreylgv commented 1 year ago

Hello @CBID2, no prob, you can. I wanted to start by forking this repo and creating a navbar branch and submit a PR, wouldn't we have merge problems?

CBID2 commented 1 year ago

Hello @CBID2, no prob, you can.

I wanted to start by forking this repo and creating a navbar branch and submit a PR, wouldn't we have merge problems?

I thought you forked this repo already @geoffreylgv?

geoffreylgv commented 1 year ago

Hello @CBID2, no prob, you can. I wanted to start by forking this repo and creating a navbar branch and submit a PR, wouldn't we have merge problems?

I thought you forked this repo already @geoffreylgv?

Not yet

CBID2 commented 1 year ago

Hello @CBID2, no prob, you can. I wanted to start by forking this repo and creating a navbar branch and submit a PR, wouldn't we have merge problems?

I thought you forked this repo already @geoffreylgv?

Not yet

Ooh, I see @geoffreylgv. To save time, I recommend cherry-picking the commit you did for the navbar to your PR.

geoffreylgv commented 1 year ago

Hello @CBID2, no prob, you can. I wanted to start by forking this repo and creating a navbar branch and submit a PR, wouldn't we have merge problems?

I thought you forked this repo already @geoffreylgv?

Not yet

Ooh, I see @geoffreylgv. To save time, I recommend cherry-picking the commit you did for the navbar to your PR.

Alright 👍🏾

geoffreylgv commented 1 year ago

One question, if I fork this repo (thing I already did), how do I have the changes you have on your branch @CBID2 ? I mean, every translation we did so far

CBID2 commented 1 year ago

One question, if I fork this repo (thing I already did), how do I have the changes you have on your branch @CBID2 ? I mean, every translation we did so far

I found this: https://medium.com/@satorusasozaki/move-all-commits-to-another-repository-2a3506ca3ed5

geoffreylgv commented 1 year ago

One question, if I fork this repo (thing I already did), how do I have the changes you have on your branch @CBID2 ? I mean, every translation we did so far

I found this: https://medium.com/@satorusasozaki/move-all-commits-to-another-repository-2a3506ca3ed5

Ok, thanks

CBID2 commented 1 year ago

One question, if I fork this repo (thing I already did), how do I have the changes you have on your branch @CBID2 ? I mean, every translation we did so far

I found this: https://medium.com/@satorusasozaki/move-all-commits-to-another-repository-2a3506ca3ed5

Ok, thanks

Let me know if you manage to do it @geoffreylgv.

geoffreylgv commented 1 year ago

One question, if I fork this repo (thing I already did), how do I have the changes you have on your branch @CBID2 ? I mean, every translation we did so far

I found this: https://medium.com/@satorusasozaki/move-all-commits-to-another-repository-2a3506ca3ed5

Ok, thanks

Let me know if you manage to do it @geoffreylgv.

Morning @CBID2 , Yes did it