open-services-group / scrum

SCRUM issues and user stories
GNU General Public License v3.0
0 stars 2 forks source link

documentation of the pipeline, source repos, target clusters, build from branch? #32

Closed goern closed 1 year ago

goern commented 1 year ago

As a BYON/CNBi developer, I want to read up how and where the components I work on get deployed, so that I can build and deploy development branches

schwesig commented 1 year ago

/kind feature /kind documentation

codificat commented 1 year ago

Status update:

The target cluster for CNBi CD is OSC's osc-cl1 cluster.

Deployment of opendatahub is driven by the odh-manifests repo:

ArgoCD deploys BYON's version of the odh-dashboard in the opf-jupyterhub-stage namespace (as configured in the apps repo). That image is built from https://github.com/opendatahub-io/odh-dashboard/tree/BYON and available at quay.io/repository/operate-first/odh-dashboard:byon.

Right now, accessing the settings → notebook images (https://odh-dashboard-opf-jupyterhub-stage.apps.odh-cl1.apps.os-climate.org/notebookImages) crashes (blank page), with this logged in the browser's js console:

TypeError: t is undefined
    ae NotebookImagesTable.tsx:130
    ae NotebookImagesTable.tsx:126
    React 6
    unstable_runWithPriority scheduler.production.min.js:19
    React 5
    a useWatchNotebookImages.tsx:38
    promise callback*a useWatchNotebookImages.tsx:35
    o useWatchNotebookImages.tsx:45
    React 2
    unstable_runWithPriority scheduler.production.min.js:19
    React 3
    B scheduler.production.min.js:17
    onmessage scheduler.production.min.js:14
react-dom.production.min.js:209:194
    React 5
    unstable_runWithPriority scheduler.production.min.js:19
    React 4
    unstable_runWithPriority scheduler.production.min.js:19
    React 5
    a useWatchNotebookImages.tsx:38
    (Async: promise callback)
    a useWatchNotebookImages.tsx:35
    o useWatchNotebookImages.tsx:45
    React 2
    unstable_runWithPriority scheduler.production.min.js:19
    React 3
    B scheduler.production.min.js:17
    onmessage scheduler.production.min.js:14

The stage namespace also has a manifest of the BYON validation/import pipeline:

$ tkn p ls
NAME                           AGE            LAST RUN                                 STARTED        DURATION   STATUS
byon-import-jupyterhub-image   15 weeks ago   byon-import-jupyterhub-image-run-r8jc6   14 weeks ago   1 minute   Succeeded

This seems to have been manually deployed.

Question: @goern where do you think is the best place to persist this type of documentation? ODH? Operate First?

codificat commented 1 year ago

The stage namespace also has a manifest of the BYON validation/import pipeline: This seems to have been manually deployed.

It is not manually deployed: the pipeline manifest comes from ODH: https://github.com/operate-first/odh-manifests/tree/osc-cl1-byon/jupyterhub/jupyterhub/overlays/byon

codificat commented 1 year ago

Question: @goern where do you think is the best place to persist this type of documentation? ODH? Operate First?

Answering myself: this will be documented in the new https://github.com/thoth-station/opendatahub-cnbi/ repository

codificat commented 1 year ago

/assign /lifecycle active /triage accepted

codificat commented 1 year ago

The initial documentation was added in https://github.com/thoth-station/opendatahub-cnbi/pull/6

Further updates should come as part of the work on https://github.com/thoth-station/opendatahub-cnbi/issues/20 /close

sesheta commented 1 year ago

@codificat: Closing this issue.

In response to [this](https://github.com/open-services-group/scrum/issues/32#issuecomment-1268867442): >The initial documentation was added in https://github.com/thoth-station/opendatahub-cnbi/pull/6 > >Further updates should come as part of the work on https://github.com/thoth-station/opendatahub-cnbi/issues/20 >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.