search

open-spaced-repetition / fsrs-optimizer

FSRS Optimizer Package
https://pypi.org/project/FSRS-Optimizer/
BSD 3-Clause "New" or "Revised" License
62 stars 12 forks source link

Feat/use median in calculating recall cost, forget cost and learn cost #109

Closed L-M-Sherlock closed 4 months ago

Expertium commented 4 months ago

Are zeros removed? As user1823 said, we should remove all values that are precisely equal to 0.

L-M-Sherlock commented 4 months ago

Are zeros removed? As user1823 said, we should remove all values that are precisely equal to 0.

Should these revlogs be removed in training?

Expertium commented 4 months ago

No, I meant that if review time=0 ms, it should be excluded from the median calculation. Though it might be a good idea to exclude them from everything. @user1823 thoughts?

user1823 commented 4 months ago

Though it might be a good idea to exclude them from everything.

I don't think that we should filter them during training the parameters unless someone gives us a specific scenario where they cause a problem.

L-M-Sherlock commented 4 months ago

Now zero values have been removed in calculating the cost.

user1823 commented 4 months ago

I can't verify the accuracy of the code but broadly it looks good to me.

user1823 commented 4 months ago

Wait a minute, I couldn't find anything that removes the reviews with time > 20 min.

Expertium commented 4 months ago

I couldn't find anything that removes the reviews with time > 20 min.

Yeah, those should be excluded.

L-M-Sherlock commented 4 months ago

Thanks for reviews!