Should FOLDER.json be defined in the ehr.directory component?

openEHR / specifications-ITS-JSON

JSON-Schema Specifications

Apache License 2.0

8 stars 5 forks source link

Should FOLDER.json be defined in the ehr.directory component? #3

Open ppazos opened 5 years ago

ppazos commented 5 years ago

Right now is under common: https://github.com/openEHR/specifications-ITS-JSON/blob/e141d638095292e8fca087d0496501df8c286365/components/RM/Release-1.0.4/Common/FOLDER.json

Ref to the class diagram: https://specifications.openehr.org/releases/RM/latest/UML/diagrams/RM-ehr.svg

sebastian-iancu commented 5 years ago

This repo file structure follows UML definition (xmi file) and specs in adoc: https://specifications.openehr.org/releases/RM/latest/common.html#_folder_class

ppazos commented 5 years ago

@sebastian-iancu The link you sent shows the package definition common.directory, and the link I sent doesn't show the common package, I guess that one should be fixed.

Either way, the schema is on common/FOLDER, not on common/directory/FOLDER.

sebastian-iancu commented 5 years ago

Yes, you are right, the directory level is missing from the path - but this is not the only place, for several other subchapters I deliberately flattened same way so that a) structure is less complex b) xml-schema structure is in line with json-schema. Is that level needed in a use-case that you have?