search

openMF / mobile-wallet

A reference implementation of Mifos platform wallet and payment capabilities
https://openmf.github.io/mobileapps.github.io/
228 stars 431 forks source link

Feature: Adding extra text to be share with QR code in android sharesheet in showQrActivity #1131

Open Harshad09 opened 3 years ago

Harshad09 commented 3 years ago

Summary:

Adding extra text to be shared with QR code with Intent in android Sharesheet in showQrActivity, for better user experience.

Steps to reproduce:

  1. Go to Request fragment in Payments
  2. Click on show code
  3. Click on the share icon (located at top right)
  4. Choose any app to share

Expected behavior:

The extra text should be share with a QR code to ease the user experience

Device and Android version:

Redmi Note 5 Pro Android 9 Pie custom ROM

devansh-299 commented 3 years ago

Not sure if we have the deep link handled for Scan QR functionality but in case we have the feature, it would be better to pass the deep link in the text as well.

Harshad09 commented 3 years ago

Not sure if we have the deep link handled for Scan QR functionality but in case we have the feature, it would be better to pass the deep link in the text as well.

Yes, Deep linking functionality should be there, as for now is this feature acceptable or I have some suggested changes @devansh-299

Harshad09 commented 3 years ago

PhonePe also uses this type of extra text when we share qr code.