search

openMF / mobile-wallet

A reference implementation of Mifos platform wallet and payment capabilities
https://openmf.github.io/mobileapps.github.io/
229 stars 429 forks source link

Implement Google sign-in using clean architecture #1557

Open Zaid-0504 opened 7 months ago

Zaid-0504 commented 7 months ago

Summary:

In the present code base goggle sign-in is directly implemented in Login Activity we can make it better using clean architecture and View Model Steps to reproduce:

How can we reproduce again the issue?

Expected behavior:

To handle the sign-in function at a separate thread rather than in the main UI thread Observed behavior:

The Sign-in feature is working on the main UI thread which can compromise user experience if an error occurs

Device and Android version:

What make and model device (e.g., Samsung Galaxy S3) did you encounter this on? What Android version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are you running? Is it the stock version from the manufacturer or a custom ROM?

Screenshots:

Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.

Zaid-0504 commented 7 months ago

I am willing to work on this issue can you assign me

therajanmaurya commented 6 months ago

@Zaid-0504 Can you please review again the codebase with the class name SignupMethod. I have my self implemented and converted it into compose and suggest something we can do better and then let's work on it.