search

openMF / mobile-wallet

A reference implementation of Mifos platform wallet and payment capabilities
https://openmf.github.io/mobileapps.github.io/
232 stars 439 forks source link

CodeStyle violated in Payments Fragment and Finance Fragment #298

Closed codepoet2017390 closed 2 years ago

codepoet2017390 commented 5 years ago

Summary:

The Code follows the concept of Dependency Injection using Dagger2 but this style has been violated in Payments Fragment and Finance Fragment of home package. Here are the links 1) https://github.com/openMF/mobile-wallet/blob/redesign/mifospay/src/main/java/org/mifos/mobilewallet/mifospay/home/ui/FinanceFragment.java

2) https://github.com/openMF/mobile-wallet/blob/redesign/mifospay/src/main/java/org/mifos/mobilewallet/mifospay/home/ui/PaymentsFragment.java

The setUpViewPager() method has a dependency which is called by the method itself and it is a violation of the Dependency Injection Principle.

Device and Android version: OnePlus5 Android Pie(9)

codepoet2017390 commented 5 years ago

@luckyman20 please take a look