search

openSUSE / openSUSE-welcome

Korora welcome utility adapted for openSUSE Project
Other
12 stars 20 forks source link

Should this be ported away from a web view? #34

Open LorenDB opened 8 months ago

LorenDB commented 8 months ago

I am surprised that this application is implemented as a web view inside a QML window. To me, this seems like a poor implementation, and I'd personally like to see it either embrace the webview (e.g. full Electron/Tauri mode) or (preferably) go full QML. This would result in both a lighter overall application and a cleaner, easier-to-interact-with codebase.

AFAICT, there is not really any major blocker to using QML to recreate the existing app, as it's just a page with a few buttons plus a few subpages of text, all of which is super easy to do in QML. I'd personally be happy to create a POC port to QML if nobody is opposed.

herzenschein commented 8 months ago

I can't see anything in the app blocking this at least. That could be done in conjunction with https://github.com/openSUSE/openSUSE-welcome/pull/35 since it's a major change.

LorenDB commented 8 months ago

I actually am already working on the QML port, which involved porting to Qt 6. (Actually, it's more of a massive overhaul to the codebase to bring it in line with modern standards.) I'll push a draft PR with what I've got so far.

LorenDB commented 8 months ago

@herzenschein: see #36.