search

openbankingspace / tpp-issues

34 stars 1 forks source link

HSBC - Pagination links are invalid #157

Open oliver-hohn opened 5 years ago

oliver-hohn commented 5 years ago

Since 8:19 AM Today (2nd of May), HSBC has been returning invalid links:

"Links": {
  "Self": "null/open-banking/v1.1/accounts/[ACCOUNT_ID]/transactions",
  "Next": "null/open-banking/v1.1/accounts/[ACCOUNT_ID]/transactions"
}

These invalid URIs break our integration with HSBC.

Before this incident, the links provided by HSBC looked like this:

"Links": {
  "Self": "https://private.api.hsbc.com/open-banking/v1.1/accounts/[ACCOUNT_ID]/transactions",
  "Next": "https://private.api.hsbc.com/open-banking/v1.1/accounts/[ACCOUNT_ID]/transactions?"
}

Which meant that TPPs could safely follow the Next links to fetch all of the pages for the /transactions endpoint.

This issue is present in all resource endpoints, however it is only visible on the transactions endpoint because it is the only endpoint that requires pagination due to the amount of transactions a PSU will normally have in comparison to all other resources.

Impact

Critical. Invalid links being provided prevents TPPs from being able to consume all of the transactions of a PSU, and causes TPP integrations to break when attempts are made to follow the links.

Submitted as OBSD-8501.