search

opencleveland / refundcleveland

website for residents to adjust the city of Cleveland proposed budget to reflect their priorities.
MIT License
12 stars 10 forks source link

store submission in database #57

Closed adamfishman closed 3 years ago

adamfishman commented 3 years ago

first cut of storing in db, and adding error message for trying to view submissions that don't exist

skorasaurus commented 3 years ago

Hey awesome!

I tried it a couple times out and the submissions worked (I didn't get the find my ward to work, but I didn't have a valid google key to plug in)

I noticed that if a user puts a non-integer value into the ward field at /submit ; they'll receive an ValueError at /store-data/ ; I'm stepping away right now for an hour or 2 but we could enforce the integer much more elegantly to the user by the input type for that particular element from 'text' to integer' (ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number)

skorasaurus commented 3 years ago

Looks good to me; :+1: