search

openclimatefix / PVNet

PVnet main repo
MIT License
17 stars 4 forks source link

Add placeholders to configs #103

Closed dfulu closed 9 months ago

dfulu commented 9 months ago

To allow many users to train this model themselves, remove the hard coded paths from the configs and add the configs to the .gitgnore. Users can edit the configs locally to their own paths

confusedmatrix commented 9 months ago

Is there any risk to existing installations of PVNet (e.g. in production) that really on these configs if we add them to .gitignore? The configs that currently exist should probably serve as defaults that can be overridden with hydra on the command line with custom configs (not sure if this already happens in our production environment)

dfulu commented 9 months ago

No there is no risk. The configs for production are version-controlled alongside the model on huggingface since each trained model might have different settings