Closed dfulu closed 4 months ago
Attention: Patch coverage is 84.21053%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 55.57%. Comparing base (
7f884f8
) to head (6471e87
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pvnet/models/base_model.py | 14.28% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
HI James, looks great! I expected to see mulite models being loaded in from HuggingFace. Or perhaps that happens in pvnet_app
.
I really would like it if you add something to experiments to, showing the impact of aggregation? Can be 1 paragraph with a few graphs would be fanstastic.
HI James, looks great! I expected to see mulite models being loaded in from HuggingFace. Or perhaps that happens in pvnet_app.
We compile multiple models into a single ensemble model. Thats what the new Ensemble
class is for. It contains a list of submodels which are trained separately. Once we compile an Ensemble
from a list of trained models, we push the whole thing to huggingface as if is was a single model (which in a pytorch sense it really is now). I think it simplifies the huggingface workflow, and means we don't have to make any changes to pvnet_app
to accommodate it. The app is oblivious that it is running an ensemble
Pull Request
Description
Add support for using a ensemble of models in production
Changes:
Checklist: