search

openclimatefix / PVNet

PVnet main repo
MIT License
15 stars 3 forks source link

Remove properties #149

Closed dfulu closed 4 months ago

dfulu commented 4 months ago

Pull Request

Description

I've been having trouble instantiating models with hydra because of these properties. It is simpler to remove them and replace them with attributes instead.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.46%. Comparing base (27a6833) to head (8bb4564). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #149 +/- ## ========================================== - Coverage 55.57% 55.46% -0.11% ========================================== Files 31 31 Lines 2082 2077 -5 ========================================== - Hits 1157 1152 -5 Misses 925 925 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.