search

openclimatefix / PVNet

PVnet main repo
MIT License
15 stars 3 forks source link

port all weights when converting to mutimodal model object #155

Closed dfulu closed 3 months ago

dfulu commented 4 months ago

In the previous version I forgot to copy the weights from the solar coord encoder and the GSP embedding when converting the UMT into a multimodal model. This corrects the mistake.

Also added tests and a couple of minor bug fixes

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.34%. Comparing base (7e1dd3b) to head (cff5817). Report is 39 commits behind head on main.

:exclamation: Current head cff5817 differs from pull request most recent head 226bf26. Consider uploading reports for the commit 226bf26 to get more accurate results

Files Patch % Lines
pvnet/models/multimodal/unimodal_teacher.py 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #155 +/- ## ========================================== - Coverage 61.47% 61.34% -0.14% ========================================== Files 28 28 Lines 1786 1790 +4 ========================================== Hits 1098 1098 - Misses 688 692 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.