search

openclimatefix / PVNet

PVnet main repo
MIT License
15 stars 3 forks source link

`hindcast.py` is out of date #156

Open markus-kreft opened 4 months ago

markus-kreft commented 4 months ago

Describe the bug

When looking into https://github.com/openclimatefix/PVNet/issues/111 to move utility functions to ocf_datapipes I found a regressions. PVNet depends on ocf_datapipes>=3.1.5 so the latest version will be installed. In hindcast.py, the function stack_np_examples_into_batch is imported from ocf_datapipes.utils.utils, however, 21b0f95 moved it to ocf_datapipes.batch. It is already imported correctly in e.g. pvnet/data/datamodule.py.

To Reproduce

Steps to reproduce the behavior:

Expected behavior

Import works.

dfulu commented 4 months ago

Hi @markus-kreft, thanks very much for flagging this. That script has unfortunately gone out of date with the library. I have a new copy that adds some extra functionality but needs a little tidying up, so I'll fix this as soon as I get the chance.

For now, if you are working on anything else, don't worry about this script running

markus-kreft commented 4 months ago

Thanks for clarifying. Makes also sense then that some other imports did not work as expected. I will leave this for now, but am happy to help clean up/add to CI when you added the extra functionality.