openclimatefix / PVNet

PVnet main repo

MIT License

15 stars 3 forks source link

Update packaging #183

Closed mahdilamb closed 1 month ago

mahdilamb commented 2 months ago

Pull Request

Description

Remove setup.py and requirements*.txt files and merge into pyproject.toml

Fixes #

How Has This Been Tested?

Per CI/CD

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

peterdudfield commented 2 months ago

Hi @mahdilamb, thanks so much for doing all this. Some of our users use conda, do you know if conda can use a pyproject.toml

mahdilamb commented 2 months ago

Hi @peterdudfield, I'd expect so since it's the 'standard' way since PEP621, but I could be mistaken!

mahdilamb commented 2 months ago

Just doing a bit of reading. It seems that it may be possible to have it run in conda (I haven't used it in years, so can't say for sure).

https://github.com/conda/conda/issues/10633 seems to suggest that most of it is implemented.

It is also possible to have the dependencies dynamic (i.e. read into pyproject from a requirements.txt file), which will satisfy both standard packaging and conda? Happy to update.