openclimatefix / PVNet

PVnet main repo
MIT License
15 stars 3 forks source link

config - missing `number of batches` and `batch_output_dir` #197

Closed peterdudfield closed 1 month ago

peterdudfield commented 1 month ago

Missing variables in configs.example

This is needed for creating batches

Could we add these in?

peterdudfield commented 1 month ago

@AUdaltsova @Sukh-P

Sukh-P commented 1 month ago

Yeah good point, at the moment I think you can add them in when running the the save_batches script by adding + batch_output_dir="example_dir" for example when running the command but would be good to have this in the config example rather than needing to add that each time, maybe it's worth putting it here since this is the batch creation related config? Would need to change the save batches script slightly to refer to config_dm rather than config in places like this if so

peterdudfield commented 1 month ago

Yea, I thought put them in the configs.example/config.yaml, but yea your right it makes more sense having them in the datamodel bit