openclimatefix / PVNet

PVnet main repo
MIT License
21 stars 5 forks source link

Fix history bug and add bells in analysis.py #241

Closed AUdaltsova closed 3 months ago

AUdaltsova commented 3 months ago

Pull Request

Description

Analysis.py results were inconsistent because run.history() was pulling 500 random steps instead of the whole history. Fixed that.

Bells and whistles:

How Has This Been Tested?

Ran analysis.py several times for the same set of runs to make sure it gave consistent results; separately tested that run.lastHistoryStep was working as expected

Checklist:

AUdaltsova commented 3 months ago

@peterdudfield turns out I made the change and never merged, mind taking a quick look when you have a minute?