openclimatefix / PVNet

PVnet main repo

MIT License

21 stars 5 forks source link

Fix wandb artifact saving in base_model.py #254

Closed AUdaltsova closed 2 months ago

AUdaltsova commented 2 months ago

Pull Request

Description

Changed val results artifact name for wandb to not contain restricted characters. Otherwise was getting this error:

Artifact name may only contain alphanumeric characters, dashes, underscores, and dots. Invalid name: validation_results_epoch=0

How Has This Been Tested?

Ran training with the fix and synced the result to wandb, now the artifacts get saved

[X] Yes

Checklist:

[X] My code follows OCF's coding style guidelines
[X] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] I have checked my code and corrected any misspellings