openclimatefix / PVNet

PVnet main repo
MIT License
17 stars 3 forks source link

Filter quantile metrics to avoid problems at night #58

Closed dfulu closed 1 year ago

dfulu commented 1 year ago

Pull Request

Description

Filter metrics computing the number of values below the predicted quantiles to avoid issues at night. These metrics don't work well where everything should be zero

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #58 (7c5b065) into main (fcbbbe5) will decrease coverage by 0.09%. The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   68.23%   68.15%   -0.09%     
==========================================
  Files          22       22              
  Lines        1615     1617       +2     
==========================================
  Hits         1102     1102              
- Misses        513      515       +2     
Impacted Files Coverage Δ
pvnet/models/base_model.py 39.36% <0.00%> (-0.43%) :arrow_down:
pvnet/__init__.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more