search

openclimatefix / PVNet

PVnet main repo
MIT License
17 stars 3 forks source link

Installation inconsistency #61

Closed tomasvanoyen closed 1 year ago

tomasvanoyen commented 1 year ago

Describe the bug

Hi I am trying to install PVnet. There appears to be an inconsistency in the requirements. In particular,

PVNet asks for nowcasting_datamodel==1.4.0, and also nowcasting_utils. The latter in turn requests nowcasting_dataset, which in turn requires nowcasting_datamodel>=1.4.4.

I do not know yet if this imposes serious problems on the code but it is inconsistent, and would be nice to resolve.

Regards,

Tomas

dfulu commented 1 year ago

Hi @tomasvanoyen, thanks for this issue. I'll look at updating the requirements

dfulu commented 1 year ago

@tomasvanoyen, as far as I can tell, this requirement clash was already fixed in #32, and further updated in #45.

PVNet now asks for nowcasting_datamodel==1.4.14, so I think this is solved

tomasvanoyen commented 1 year ago

okay! thanks!