Closed dfulu closed 1 year ago
Merging #74 (33469aa) into main (ef9be5b) will increase coverage by
0.07%
. Report is 1 commits behind head on main. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 68.76% 68.83% +0.07%
==========================================
Files 22 22
Lines 1668 1672 +4
==========================================
+ Hits 1147 1151 +4
Misses 521 521
Files Changed | Coverage Δ | |
---|---|---|
pvnet/__init__.py | 100.00% <100.00%> (ø) |
|
pvnet/app.py | 92.70% <100.00%> (+0.15%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Did you try it locally? did it work?
Yeh, I ran the container locally and it works. Doesn't need to download the model in the app anymore
Pull Request
Description
Add default models to the docker image. The models are on the order of 100MB in size for pvnet and the summation model. The models will be saved to the on-disk model cache and this means we do not need to download them from huggingface each time we run the app.
This seems neater and makes us less susceptible to rare huggingface outages, as happened today.
Checklist: