openclimatefix / PVNet

PVnet main repo
MIT License
20 stars 5 forks source link

PVNet Torchdata now conflicts with ocf_datapipes DataPipes #94

Closed jacobbieker closed 11 months ago

jacobbieker commented 11 months ago

Describe the bug

Since development of torchdata is on pause github.com/pytorch/data we switched ocf_datapipes over to using the now built-in PyTorch datapipes. This causes issues with PVNet, as there are some duplicate datapipe names now between the torchdata ones and the PyTorch DataPipes ones.

We can probably switch PVNet to use the internal PyTorch datapipes now, it does involve removing DataLoader2 though, as not everything was copied over to the core PyTorch one

jacobbieker commented 11 months ago

Closed with #95