Migrate RelEx to maven - Githubissues

opencog / relex

English Dependency Relationship Extractor

http://wiki.opencog.org/w/RelEx

Apache License 2.0

85 stars 68 forks source link

Migrate RelEx to maven #267

Closed vsbogd closed 5 years ago

vsbogd commented 6 years ago

See second part of the https://github.com/opencog/relex/issues/100#issuecomment-48514712.

Maven can manage most of dependencies automatically so it will simplify build procedure. It has a plugin to automate ready to run environment createion (see https://github.com/opencog/relex/issues/266)

noskill commented 6 years ago

Anything else to do here?

vsbogd commented 6 years ago

It is needed to create maven artifacts to replace manually written scripts like opencog-server.sh and relation-extractor.sh. In fact all of *.sh scripts in the root project folder.

linas commented 6 years ago

Well, the *.sh scripts were meant to be "examples", that the user could modify to suit their purposes. So whatever they are replaced with, they should also be "examples", and be labeled as such, and should somehow be easy and obvious to understand.

--linas

On Sun, Sep 9, 2018 at 9:27 PM, Vitaly Bogdanov notifications@github.com wrote:

It is needed to create maven artifacts to replace manually written scripts like opencog-server.sh and relation-extractor.sh. In fact all of *.sh scripts in the root project folder.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/opencog/relex/issues/267#issuecomment-419715990, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFwoBKhOlZdItbTOlpuNSV3cPAD5ji-ks5uZRcwgaJpZM4VPwmP .

-- cassette tapes - analog TV - film cameras - you

vsbogd commented 6 years ago

Actually I thought about it again and looks like the simplest way is to collect all of the dependencies in one folder using maven and then use them as classpath in existing scripts. Then scripts themselves will not be changed, only classpath will be.

I have raised https://github.com/opencog/relex/pull/276 to collect dependencies. And I see the following further steps:

fix classpath in *.sh scripts to use ./target/lib/*.jar files collected by maven; I already committed it see https://github.com/vsbogd/relex/commit/57930c03286c6c79d587383b7b022dfd23a07faf but this work cannot be merged without next steps.
edit docker/Dockerfile to use maven to build relex within docker image
update README.md
remove ant scripts

linas commented 5 years ago

Is the work here finished? Can this be closed?

vsbogd commented 5 years ago

Yes, thanks