search

opencog / relex

English Dependency Relationship Extractor
http://wiki.opencog.org/w/RelEx
Apache License 2.0
85 stars 68 forks source link

#271 Remove EnglishSD.bin.gz usages #272

Closed stellarspot closed 6 years ago

stellarspot commented 6 years ago

According to the 5a5188ca03ed0f06efbf57af0f7141288038a7ef change the OpenNLP 1.4 version is not used in the project.

Current changes:

linas commented 6 years ago

Thanks!

whitten commented 6 years ago

What is the impact of removing 1.3 and 1.4 support, and removing the EnglishSD.bin.gz ? Do we still have people using these older versions? Is there any loss from removing EnglishSD stuff ? Is it duplicating information available elsewhere in later versions? Inquiring Minds want to know, Dave Whitten 713-870-3834 I know you said the old data model is not being used. Is the newer version using the same kind of statistical analysis, or is this abandoning an approach that used to work ?

linas commented 6 years ago

Hi @whitten I believe that support 1.5.3 was added circa 2014, and that support for 1.4 was added circa 2009, and 1.3 is older than that. If you haven't upgraded relex since 2009 ... I don't know what to say. There have been binary-incompatible fixes to the java API's between relex and link-grammar in the circa-2014 time frame. Also link-grammar has improved by light-years since 2009, and relex has had significant changes in 2014, breaking some things but fixing many more ....

Proper versioning for relex would help avoid these kinds of binary-incompatibility messes, as well as avoid functional support sideways slip. However, We've been sloppy about that. There's a version numbering scheme in there, but no one ever bumps the version number.

If you want to get pro-active, and tag certain git versions with certain tags, open new pull requests for them, or at least new github issues.