#267 migrate relex to maven

opencog / relex

English Dependency Relationship Extractor

http://wiki.opencog.org/w/RelEx

Apache License 2.0

85 stars 68 forks source link

#267 migrate relex to maven #282

Closed stellarspot closed 5 years ago

stellarspot commented 5 years ago

Proposed changes to use maven as the only one build tool for RelEx:

install-ubuntu-dependencies.sh is updated to build ReleEx by 'mvn package' and 'mvn install' commands
Dockerfile is updated
- use JDK 8
- install link-grammar jar library to maven local repository
- build RelEx by maven
Scripts are updated to use libraries from Maven target directory

The http://github.com/opencog/relex/archive/master.zip should be updated together with the current fix because Docker file uses it to build RelEx.

vsbogd commented 5 years ago

Please fix README.md as well:

all dependencies except Wordnet could be removed as they will be automatically managed by maven
Building with Ant section could be removed

stellarspot commented 5 years ago

I updated the README to not mention jar libraries which are installed by maven and removed the building RelEx by Ant chapter.

stellarspot commented 5 years ago

I have a question about the 'vagrant' user used in the install-ubuntu-dependencies script. Is it still used in somewhere?

vsbogd commented 5 years ago

I have a question about the 'vagrant' user used in the install-ubuntu-dependencies script. Is it still used in somewhere?

I don't have an answer on this question, @linas, do you know?

linas commented 5 years ago

vagrant

As far as I know, no one uses this. I think it was intended to make things easy/easier for Windows users.

linas commented 5 years ago

one used to be able to run the unit tests, by saying ant test -- how will this work with maven? Does it still work?

vsbogd commented 5 years ago

Yes, maven mvn test runs unit tests. But as far as I see project structure should be corrected to run them. @stellarspot , have you tried mvn test?

stellarspot commented 5 years ago

@stellarspot , have you tried mvn test?

Just forgot about tests. I updated the test to run them using Maven:

JUnit annotations are added to the test files
java.library.path is set in the pom.xml file for maven-surefire-plugin

linas commented 5 years ago

How about this: I'll merge now, if more changes are needed a new pull req. OK?