opencypher / openCypher

Specification of the Cypher property graph query language
http://www.opencypher.org
Apache License 2.0
853 stars 149 forks source link

Fill feature expressions/pattern/Pattern2 #491

Closed hvub closed 3 years ago

hvub commented 3 years ago

This PR aims at providing scenarios for the so far empty feature expressions/pattern/Pattern2.

hvub commented 3 years ago
hvub commented 3 years ago

Ad "add scenario on size(<pattern comprehension>) to list/List6":

The scenarios pattern/Pattern3.[4], pattern/Pattern3.[7][9] testing on size(<pattern comprehension>). I will simply move them over to list/List6. The scenarios are not picture-prefect and could be improved. Let's not do this now, but rather as a part of improving/completing list/List6 whenever that comes up.

hvub commented 3 years ago

Thanks @Mats-SX, though in general I have to say, I did not came up with these scenarios, they existed already (in Pattern3). They certainly can be improved. However, that is not the aim of this PR. This PR aimed at providing scenarios for size(<pattern>) (originally Pattern2) which turned out to be deprecated. Hence, this PR removes the feature Pattern2 provisioned for size(<pattern>) and renames Pattern3 to Pattern2.

Anyway, some improvements have be made. More can be made at some later stage. At the moment, we try to focus on filling complete empty features.

Mats-SX commented 3 years ago

@hvub Thanks a lot! Happy to approve this :)