Expose API Server and Envoy endpoints and add a new Envoy condition - Githubissues

opendatahub-io / data-science-pipelines-operator

Apache License 2.0

12 stars 49 forks source link

Expose API Server and Envoy endpoints and add a new Envoy condition #669

Closed rimolive closed 2 months ago

rimolive commented 4 months ago

The issue resolved by this Pull Request:

Resolves RHOAIENG-7929

Description of your changes:

This PR will introduce a new condition to check if MLMD Envoy is ready (EnvoyReady) and add the DSPA endpoints (API Server and MLMD Envoy) to the status field.

Testing instructions

Build the operator pod, or use the one that GitHub will create

Deploy DSPO:

export IMAGE_NAME="" # Change to the image you built or the one GitHub generated
make deploy IMG=$IMAGE_NAME OPERATOR_NS=opendatahub # Ensure you have opendatahub namespace created and no resources created in it

Deploy the dspa_simple.yaml file

Run the following command (ensure you ran oc login first):

oc get DataSciencePipelinesApplication sample -o yaml | yq .status.components

You should receive an output like this:

apiServer:
externalUrl: https://ds-pipeline-sample-dspa.apps.example.com
url: https://ds-pipeline-sample.dspa.svc.cluster.local:8443
mlmdProxy:
externalUrl: https://ds-pipeline-md-sample-dspa.apps.example.com
url: http://ds-pipeline-md-sample.dspa.svc.cluster.local:9090

Ensure unit tests are passing. Run the following in the repo root path:
```
make unittests
```

Checklist

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work

dsp-developers commented 4 months ago

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669 An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/669/head
git checkout -b pullrequest 21e6dfedf811fabf84f8d812edf727e53f528d6b
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-669"

More instructions here on how to deploy and test a Data Science Pipelines Application.

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

dsp-developers commented 3 months ago

Change to PR detected. A new PR build was completed. A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-669

Next