Preserve svc cluster ips by default

opendevstack / tailor

Infrastructure as Code for OpenShift

Apache License 2.0

13 stars 9 forks source link

Preserve svc cluster ips by default #242

Closed felipecruz91 closed 3 years ago

felipecruz91 commented 3 years ago

Note that I haven't added any extra e2e tests covering this feature given that Github Actions spins up an OpenShift 3 cluster and this is a fix for an OpenShift 4.7+ cluster.

felipecruz91 commented 3 years ago

@michaelsauter If this is change is fine, would you publish a new release so we can start using it right away? 😉

michaelsauter commented 3 years ago

@felipecruz91 I think this is not the right place as the default will be overwritten when a user specified their own paths.

The right place should be https://github.com/opendevstack/tailor/blob/master/pkg/openshift/item.go#L29, but it seems to be there already so maybe try with master?

michaelsauter commented 3 years ago

Should be in v1.3.1, see https://github.com/opendevstack/tailor/commit/3c069c203ee5554a1d852319c176b7c7f303599a#diff-35a967729e47264928ca87cce4c17d076ae0769cae84b224a4058101de2975a4.

felipecruz91 commented 3 years ago

Cool then, we'll target v1.3.1 then and will let you know, thank you

felipecruz91 commented 3 years ago

@michaelsauter We used v1.3.1 and didn't work - shouldn't it be "/spec/clusterIPs" (plural) instead of "/spec/clusterIP" ?

https://github.com/opendevstack/tailor/commit/3c069c203ee5554a1d852319c176b7c7f303599a#diff-35a967729e47264928ca87cce4c17d076ae0769cae84b224a4058101de2975a4R29

felipecruz91 commented 3 years ago

@michaelsauter Ok, I've added both now

michaelsauter commented 3 years ago

Released in 1.3.2