search

opendoor-labs / gozw

Fork of a fork of a fork (Use https://github.com/gozwave/gozw as the upstream)
https://github.com/gozwave/gozw
MIT License
1 stars 2 forks source link

Revert "Merge pull request #18 from opendoor-labs/ss-prune-nodes" #33

Closed zacatac closed 5 years ago

zacatac commented 5 years ago

This reverts commit ecd542041250772cdfce0edee7865da93a16b3ca, reversing changes made to bc5cb5e5588c7b4ac9edeed321e008f282e6eb6e.

We're still unsure what the root cause is, but we've identified through binary search that this commit contains changes which have broken the pairing process for Razberry hats. We still need to test against other Z-Wave chips.

parrotmac commented 5 years ago

Just want to call out that this will probably break some UI elements in Sailor -- saying nothing of the need for actual testing.

zacatac commented 5 years ago

After doing some more testing I'm not convinced that reverting this makes the pairing process any less flaky. Will reopen if necessary.