openebs / mayastor

Dynamically provision Stateful Persistent Replicated Cluster-wide Fabric Volumes & Filesystems for Kubernetes that is provisioned from an optimized NVME SPDK backend data storage stack.
Apache License 2.0
750 stars 109 forks source link

bitnami/bitnami-shell deprecated will be removed July 2024 #1689

Open ThorbenJ opened 4 months ago

ThorbenJ commented 4 months ago

Describe the bug While trying to debug why ectd won't start on arm64, I found the initcontain is using an old image version: bitnami/bitnami-shell:11-debian-11-r63 This version lacks arm64, the latest version 11-debian-11-r99 has both arm64 and amd64. However the bigger issue maybe:

🛑 Deprecation Notice

The Bitnami Shell container is no longer maintained and is now deprecated in favor of OS Shell. This image will no longer be released in our catalog, but already released container images will persist in the registries until July 2024.

After that time, this repository will be fully removed in favor of bitnami/bitnami-shell-archived where all existing images can be found.

I note the latest os-shell supports both amd64 and arm64 too.

Steps to reproduce the behavior:

Read https://hub.docker.com/r/bitnami/bitnami-shell

OS info (please complete the following information):

Additional context I imagine amd64 deployments will start breaking when they pull the images from the registry. Silver linning for me, upgrading to a newer image (os-shell for example) would win my arm64 support =)

ThorbenJ commented 4 months ago

I updated the etcd statefulset to use: os-shell:12-debian-12-r25 etcd:3.5.14-debian-12-r4

tiagolobocastro commented 4 months ago

Hey @ThorbenJ, coincidentally the next releases should hopefully not be using those (https://github.com/openebs/mayastor-extensions/commit/cbc271819a44a258762ece42b0c899c3542f9eb4) Though I think we'll have to check, there may be something else using them.

We also had a request to explicitly list which images we require (for air-gapped) and I've been thinking about adding this list plus a test to ensure the list remains correct, maybe we can then check if there's any other use of bitnami-shell.

avishnu commented 1 month ago

The fix is available in the develop charts and will be part of the v4.2 release.