openebs / mayastor

Dynamically provision Stateful Persistent Replicated Cluster-wide Fabric Volumes & Filesystems for Kubernetes that is provisioned from an optimized NVME SPDK backend data storage stack.
Apache License 2.0
740 stars 106 forks source link

InitContainers - Handle builtin kernel modules #1704

Open tiagolobocastro opened 3 months ago

tiagolobocastro commented 3 months ago

Describe the bug Some components, by default, use init containers to check for nvme kernel modules. The problem is these modules might actually get compiled builtin, and these checks are failing in this case.

To Reproduce Install on nodes with builtin nvme-tcp kernel modules.

Expected behavior InitContainer should not fail.

OS info (please complete the following information):

CloudFocused commented 2 months ago

Thanks for all your hard work on this! I just ran into this one. The link suggests disabling init_containers. While this is being worked on, how can I disable init_containers?

tiagolobocastro commented 2 months ago

Hey, I think you need to disable like so for example, if you use mayastor chart directly: helm upgrade mayastor mayastor/mayastor -n mayastor --reuse-values --set "csi.node.initContainers.enabled=false"

edrob999 commented 2 months ago

@CloudFocused I work with @tiagolobocastro on the futures for Mayastor. If you're open to talking about your experiences, and what you're doing, let me know (you can reply here or DM me). Ed

CloudFocused commented 2 months ago

You are right @tiagolobocastro - That did it. Thanks!

avishnu commented 4 days ago

Scoping this for v4.2