search

openenclave / oeedger8r-cpp

An implementation of oeedger8r in C++
MIT License
8 stars 13 forks source link

Support deepcopy of variable length out parameters #55

Closed mingweishih closed 3 years ago

mingweishih commented 4 years ago

The PoC of supporting deepcopy over variable length out parameters. The goal is initiating the discussion on the design.

Signed-off-by: Ming-Wei Shih mishih@microsoft.com

oe-ci-robot commented 4 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

oe-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mingweishih

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openenclave/oeedger8r-cpp/blob/master/OWNERS)~~ [mingweishih] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BRMcLaren commented 3 years ago

/test all

BRMcLaren commented 3 years ago

/close

oe-ci-robot commented 3 years ago

@BRMcLaren: Closed this PR.

In response to [this](https://github.com/openenclave/oeedger8r-cpp/pull/55#issuecomment-756410495): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
BRMcLaren commented 3 years ago

/reopen

anakrish commented 3 years ago

Great work! /lgtm

anakrish commented 3 years ago

/retest

anakrish commented 3 years ago

/test all