openenclave / oeedger8r-cpp

An implementation of oeedger8r in C++
MIT License
8 stars 13 forks source link

Set count to one by default and prevent the use of size for user-defined #77

Closed mingweishih closed 3 years ago

mingweishih commented 3 years ago

This PR allows a user-defined type to have a default count equal to one if the count attribute is not specified. Also, prevent the use of size attributes with the user-defined type argument, which us not supported.

Signed-off-by: Ming-Wei Shih mishih@microsoft.com

mingweishih commented 3 years ago

/approve

oe-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manojrupireddy, mingweishih

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openenclave/oeedger8r-cpp/blob/master/OWNERS)~~ [manojrupireddy,mingweishih] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mingweishih commented 3 years ago

/lgtm

oe-ci-robot commented 3 years ago

@mingweishih: you cannot LGTM your own PR.

In response to [this](https://github.com/openenclave/oeedger8r-cpp/pull/77#issuecomment-825076563): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mingweishih commented 3 years ago

@manojrupireddy can you do /lgtm?

BRMcLaren commented 3 years ago

@manojrupireddy just a friendly heads up. For any repo in the openenclave org, other than the sdk it uses a different CI. It's approval is based on the labels applied. Each PR needs a /lgtm and an /approve. The edge case here is that anyone who owns the root repo is automatically approved so just the /lgtm is needed.

BRMcLaren commented 3 years ago

/lgtm

manojrupireddy commented 3 years ago

/lgtm