Ajout le déploiement continu du site

openfisca / fr.openfisca.org

Le site web d'OpenFisca-France. / OpenFisca-France web site.

GNU Affero General Public License v3.0

2 stars 3 forks source link

Ajout le déploiement continu du site #10

Closed sandcha closed 6 years ago

sandcha commented 6 years ago

Fixes #5

Ajout du script de déploiement
Appel du script par CircleCi lors d'un merge sur master.

sandcha commented 6 years ago

In order to find a consistent process in our websites, @maukoquiroga @Anna-Livia, what do you think? Should we keep a CHANGELOG in our websites? Should we enforce version bump and make it a condition for deployment on fr.openfisca.org, openfisca.org? legislation explorer seems different to me as it depends on core version.

Anna-Livia commented 6 years ago

I like having a changelog, however, I'm not that keen on having version numbers.

fpagnoux commented 6 years ago

Like @Anna-Livia, I think a Changelog may bring good coding hygiene, but a version number for a front end doesn't seem to bring much.

MattiSG commented 6 years ago

What would be the goal of investing in maintaining a changelog and bumping version numbers for a presentational website? 🙂

bonjourmauko commented 6 years ago

I've changed my mind : I'm actually OK with the changelog (although versioning is too much).

What would be the goal of investing in maintaining a changelog and bumping version numbers for a presentational website?

@MattiSG For the changelog, code hygiene, for the versioning, none.

@sandcha I think semver may be overkill (what would be a major version ?). A simple link to the pull request is enough IMHO.

poke @fpagnoux

bonjourmauko commented 6 years ago

Good catch !

bonjourmauko commented 6 years ago

I did approve it, sorry my fault didn't see the WIP

bonjourmauko commented 6 years ago

Do not forget to rebase before merging.

sandcha commented 6 years ago

The last build doesn't call deployment script (as not on master branch) but this #84 one does and there is no command change between them.

This PR requires:

a chmod +x deploy.sh -> commit in this branch (also done on server for #84 build and reverted).
access rights for openfisca user on /node_modules & /.next -> done on server
a call to visudo to add openfisca ALL=(ALL) NOPASSWD: /bin/systemctl restart fr.openfisca.org-beta.service -> done on server

And two SSH keys:

CircleCI -> Server (ssh connection)
Server -> GitHub (git pull)

sandcha commented 6 years ago

Condition removed on version and CHANGELOG as discussed earlier (test on update or CHANGELOG deletion could be done in an other PR).

bonjourmauko commented 6 years ago

poke @fpagnoux